求大佬们优化一下代码，屎山代码给孩子头皮想破了

秉着不写垃圾代码的原则，求大佬优化一下，最优值奉上红包
需求是这样的：

万恶后端传过来的数据：
"data":[{"province":"上海市","city":"上海市市辖区","adcode":"310118","district":"青浦区"},
{"province":"江苏","city":"苏州市","adcode":"320506","district":"吴中区"},
{"province":"山西省","city":"阳泉市","adcode":"140302","district":"城区"},
{"province":"上海市","city":"上海市市辖区","adcode":"310101","district":"黄浦区"},
{"province":"河北省","city":"石家庄市","adcode":"130123","district":"正定县"}]

需要整合成这样 elementUi 中级联选择器中的数据：
（只要有相同的就要去重并在之前的 children 下加入重复的 children ）
addressOptions: [
{
value: "zhinan",
label: "指南",
children: [
{
value: "shejiyuanze",
label: "设计原则",
children: [
{
value: "yizhi",
label: "一致",
},
{
value: "fankui",
label: "反馈",
},
{
value: "xiaolv",
label: "效率",
},
{
value: "kekong",
label: "可控",
},
],
},
{
value: "daohang",
label: "导航",
children: [
{
value: "cexiangdaohang",
label: "侧向导航",
},
{
value: "dingbudaohang",
label: "顶部导航",
},
],
},
],
},
],

我的垃圾代码：

dealWithAddressList(arr, name) {
var city = {};
return arr.reduce(function (item, ele) {
console.log(ele[name]);
if (city[ele[name]]) {
item.forEach((eles) => {
if (eles.label == ele[name]) {
eles.children.forEach((eless) => {
if (eless.value == ele.city) {
eless.children.push({
value: ele.adcode,
label: ele.district,
});
} else {
eles.children.push({
value: ele.city,
label: ele.city,
children: [
{
value: ele.adcode,
label: ele.district,
},
],
});
}
});
}
});
console.log(city[ele[name]]);
} else {
city[ele[name]] =
true &&
item.push({
value: ele.province,
label: ele.province,
children: [
{
value: ele.city,
label: ele.city,
children: [
{
value: ele.adcode,
label: ele.district,
},
],
},
],
});
}
console.log(item);
return item;
}, []);
},

求大佬优化一下，可以的话有红包奉上

ianva

2021-06-19 11:31:31 +08:00

思路就是错的，代码写的再好也是屎山

接口和组件 porps 的变化怎么隔离？不隔离接口一变，你代码也跟着变？组件换了这套代码再来一遍？一个需求变化就得重写的东西

另外一个 map 数据的代码有啥值得优化的，明确输入和输出就完了，你代码是屎，别人要重构只了解输入和输出不看你逻辑就行了

LinHoo

2021-06-19 19:17:41 +08:00

const convert = data => {
const options = []
const proviceMap = {}
data.forEach(item => {
// 没有省
if (!proviceMap[item.province]) {
proviceMap[item.province] = {
index: options.length,
citys: [item.city]
}
options.push({
value: item.province,
label: item.province,
children: [
{
value: item.city,
label: item.city,
children: [
{
value: item.adcode,
label: item.district,
}
]
}
]
})
return
}

const provinceIndex = proviceMap[item.province].index
const cityIndex = proviceMap[item.province].citys.indexOf(item.city)
// 没有市
if (cityIndex === -1) {
options[provinceIndex].children.push({
value: item.city,
label: item.city,
children: [
{
value: item.adcode,
label: item.district,
}
]
})
return
}
// 有省有市
options[provinceIndex].children[cityIndex].children.push({
value: item.adcode,
label: item.district,
})
})
}